add: unfilledEndAngle prop to Circle.js#243
Open
cwnicoletti wants to merge 3 commits intooblador:masterfrom
Open
add: unfilledEndAngle prop to Circle.js#243cwnicoletti wants to merge 3 commits intooblador:masterfrom
cwnicoletti wants to merge 3 commits intooblador:masterfrom
Conversation
…ant CIRCLE end angle
cwnicoletti
changed the title
Author
|
I forgot to include this change in the README, if you'd prefer it does let me know |
Author
|
Honestly I was thinking too, that since I'm making this into more of an arc than a circle, maybe instead of these last 2 PR, I could create a completely different loader called Arc.js |
yezhou
approved these changes
Jan 17, 2023
Owner
|
Yeah, if your use case is not a Circle, it makes more sense to add a new Arc component like you said 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking to use Progress.Circle as a semi-circle loader, however it seemed that the unfilled portion of the Circle.js component is always a constant of
const CIRCLE = Math.PI * 2. I thought I'd contribute a new prop that allows users to dynamically set the end angle of the unfilled portion of the circle with theunfilledEndAngleprop. This would allow users to make a semi-circle that's unfilled.It's written basically the same exact way as the
endAngleprop.This also makes sure no shapes are shown if
unfilledEndAngleis less than or equal to the currentstartAngleof the<Shape />component inside Circle.js. (Can be checked by turning thecolorprop torgba(0,0,0,0))